Set sidebar icon height #8333
Merged
Set sidebar icon height #8333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently icons in the side bar have no height set. This causes the iconsto use the height in the svg itself. For icons in lab whose height are hardcoded to 16px this is not an issue, but some extensions can't edit the height in the svg files and this can cause the icon height to be very large and cause issues with automated test suites. This PR sets the `height` of sidebar icons to `auto` which removes any specific height from the svg. This PR does not affect any core extensiosn and is solely to better support extenernal extensions.
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
@meeseeksdev please backport to 2.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
May 1, 2020
blink1073
pushed a commit
that referenced
this pull request
May 1, 2020
…3-on-2.1.x Backport PR #8333 on branch 2.1.x (Set sidebar icon height)
github-actions
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently icons in the side bar have no height set. This causes the
icons to use the height in the svg itself. For icons in lab whose
height are hardcoded to 16px this is not an issue, but some extensions
can't edit the height in the svg files and this can cause the icon
height to be very large and cause issues with automated test suites.
References
This issue was first found in jupyterlab/jupyterlab-git#604 and a workaround was found and used in elyra-ai/elyra#463 inspired by discussion on jupyterlab/jupyterlab-git#618
Code changes
This PR sets the
heightof sidebar icons toautowhich removesany specific height from the svg.
User-facing changes
This PR does not affect any core extensiosn and is solely to better
support external extensions.